fix(libbitcoinkernel-sys): panic with cmake output on failure#197
Draft
alexanderwiederin wants to merge 1 commit into
Draft
fix(libbitcoinkernel-sys): panic with cmake output on failure#197alexanderwiederin wants to merge 1 commit into
alexanderwiederin wants to merge 1 commit into
Conversation
Previously, cmake failures would either silently succeed (via `.unwrap()`) or only report a spawn error (via `.expect()`), making it hard to diagnose build failures. Introduce a `run_cmake` helper that captures stdout/stderr and includes them in the panic message if cmake exits non-zero. Co-authored-by: Davidson-Souza <Davidson-Souza@users.noreply.github.com>
alexanderwiederin
added
the
no-changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, cmake failures would either silently succeed (via
.unwrap()) or only report a spawn error (via.expect()), making it hard to diagnose build failures. Introduce arun_cmakehelper that captures stdout/stderr and includes them in the panic message if cmake exits non-zero.As mentioned in #158 (comment)