fix: run spell-check with pinned cspell version#505
Open
scode2277 wants to merge 1 commit into
Open
Conversation
- Replace `npx cspell` with `pnpm exec cspell` in workflow and justfile - Add `actions/setup-node` (Node 22) and pnpm setup steps - Pin new actions by SHA with version comments
frameworks-volunteer
approved these changes
May 27, 2026
Collaborator
frameworks-volunteer
left a comment
There was a problem hiding this comment.
Model: z-ai/glm-5.1 Reasoning: medium Provider: openrouter
Approved. Clean fix that eliminates an uncontrolled npx fetch in CI.
Security:
- Pinned action SHAs verified against version tags (pnpm/action-setup@0e279bb = v6.0.8, actions/setup-node@48b55a0 = v6.4.0)
pnpm exec cspellresolves from lockfile, not npm registry -- eliminates supply-chain drift- Permissions unchanged and correctly scoped
QA:
- Justfile updated to match CI --
pnpm exec cspellconsistent - Node 22 matches preview-build.yml
- One discrepancy: PR description says
pnpm install --frozen-lockfilebut the actual workflow step usespnpm installwithout the flag. Other workflows in the repo (preview-build.yml, s3-upload.yml) use--frozen-lockfile. Recommend adding it for consistency and to enforce lockfile integrity in CI. Not blocking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spell-check workflow used
npx cspell, which fetched the latest cspell from npm at runtime instead of the version pinned inpackage.json/pnpm-lock.yaml.pnpm/action-setup+actions/setup-node(Node 22) and apnpm installstep, then switched topnpm exec cspell.justfilelintto usepnpm exec cspellso local runs match CI.Frameworks PR Checklist
Thank you for contributing to the Security Frameworks! Before you open a PR, make sure to read information for contributors and take a look at the following checklist:
vocs.config.tsadding thedev: trueparameter