Skip to content

gitlint: ignore length of Signed-off-by and URL lines - #262

Merged
lsf37 merged 1 commit into
seL4:masterfrom
au-ts:julia/gitlint-long-authors-urls
May 20, 2026
Merged

lsf37 merged 1 commit into
seL4:masterfrom
au-ts:julia/gitlint-long-authors-urls

Conversation

@midnightveil

Copy link
Copy Markdown
Contributor

Issue example:
seL4/microkit#488
Cross reference:
jorisroovers/gitlint#255
https://jorisroovers.com/gitlint/latest/rules/builtin_rules/
zulip/zulip-terminal#1509

Specifically, this allows:

Co-authored-by: Someone whose name is too long to fit within 72 characters
Signed-off-by: Someone whose name is too long to fit within 72 characters
https://example.com/a/very/long/url/longer/than/72/chars
http://example.com/a/very/http/url/longer/than/72/chars
    http://example.com/an/indented/url

And does not allow (by not ignoring this case when text follows the URL)

https://example.com and continuing text that is longer than 72 characters.

There's a slight annoyance in the implementation of ignore-body-lines in that it screws with the line number reporting of errors.

@lsf37 lsf37 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. I don't think there will be any objections to this.

@lsf37
lsf37 merged commit 5121799 into seL4:master May 20, 2026
17 checks passed
@midnightveil
midnightveil deleted the julia/gitlint-long-authors-urls branch May 20, 2026 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants