Repository navigation
gitlint: ignore length of Signed-off-by and URL lines - #262
Merged
Merged
Conversation
Issue example: seL4/microkit#488 Cross reference: jorisroovers/gitlint#255 https://jorisroovers.com/gitlint/latest/rules/builtin_rules/ zulip/zulip-terminal#1509 Signed-off-by: Julia Vassiliki <julia.vassiliki@unsw.edu.au>
lsf37
approved these changes
May 20, 2026
lsf37
left a comment
Member
There was a problem hiding this comment.
Good idea. I don't think there will be any objections to this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue example:
seL4/microkit#488
Cross reference:
jorisroovers/gitlint#255
https://jorisroovers.com/gitlint/latest/rules/builtin_rules/
zulip/zulip-terminal#1509
Specifically, this allows:
And does not allow (by not ignoring this case when text follows the URL)
There's a slight annoyance in the implementation of
ignore-body-linesin that it screws with the line number reporting of errors.