Computational Art Project-Shreya Rangarajan - #9
Open
srangar03 wants to merge 1 commit into
Open
Conversation
branchwelder
reviewed
Oct 8, 2017
branchwelder
left a comment
branchwelder
left a comment
There was a problem hiding this comment.
There are some steps you could take towards making your code more readable (comments, breaking up conditionals, better variable names) but other than that this looks good.
| pass | ||
| random_list = ["prod", "avg", "cos_pi", "sin_pi"] | ||
| random_func = random.choice(random_list) | ||
| if max_depth > 0: |
There was a problem hiding this comment.
This is a giant conditional. There's nothing necessarily "wrong" with nesting conditionals this deep, but I've found that once you reach three layers of if statements it's probably best to sit back and try to understand why you need to do that, because chances are you can refactor it to be more readable. Adding comments explaining what you are doing helps as well.
| else: | ||
| return "x" | ||
| else: | ||
| if random.randint(0,1) == 1: |
There was a problem hiding this comment.
You could use return random.choice(["x", "y"]) here instead of another conditional.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.