accessibility: Make share & remix buttons more accessible#565
Open
rosics-code wants to merge 10 commits into
Open
accessibility: Make share & remix buttons more accessible#565rosics-code wants to merge 10 commits into
rosics-code wants to merge 10 commits into
Conversation
rosics-code
changed the title
Author
|
@adzhindzhi What do you think? |
rosics-code
changed the base branch from
develop
to
release/UEPR-297-accessibility-improvements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Changes remix to
$ui-green-darknew color from$pen-primaryto match from the project page. Same with share but share in the project page is still yellow.When a project is shared, the share button will have a
not-allowedcursor to make sure the person knows it's shared.Reason for Changes
Accessibility.
Test Coverage