Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #155 +/- ##
=======================================
Coverage 99.88% 99.88%
=======================================
Files 6 6
Lines 844 844
Branches 161 161
=======================================
Hits 843 843
Partials 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Merging this PR will not alter performance
Comparing Footnotes
|
Contributor
Author
|
The |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_json_schema()made shallow copies ofjson_schema_extra, then filled in nesteditemsandadditionalPropertiesdicts in place, so those writes ended up in the user's metadata. If two fields share one dict, e.g.{"items": {"description": "Tag."}}on alist[str]field and on alist[int]field of another class, the first schema adds"type": "string"to the shared dict and the second schema then reports string items too. This happened for dataclass, attrs,TypedDict, Pydantic and Scrapy items, and in one edge case for a class-level__json_schema_extra__(a dataclass with no fields whosepropertiesgot attribute docstrings written into them).This switches every
copy()of user-provided schema data in_json_schema.pytodeepcopy(), and adds tests for a shared field dict on each item type and for the class-level case. The new tests fail without the change. Thepy,extra,min-extra,docs,mypy,pylintandtwinechecktox envs and pre-commit pass.