Repository navigation
Fix boolean JSON Schema overrides for typed fields - #153
Merged
Merged
Conversation
AdrianAtZyte
approved these changes
Nov 13, 2026
wRAR
approved these changes
Nov 13, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #153 +/- ##
=======================================
Coverage 99.88% 99.88%
=======================================
Files 6 6
Lines 842 844 +2
Branches 160 161 +1
=======================================
+ Hits 841 843 +2
Partials 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Merging this PR will not alter performance
Comparing Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ItemAdapter.get_json_schema()raisesAttributeErrorwhen a typed mapping field usesjson_schema_extrawithadditionalProperties: False, such as a quantity mapping that only allows named sizes. Booleanitemsoverrides on typed sequences fail for the same reason.Preserve explicit boolean schemas instead of trying to infer types into them. Dictionary-valued schemas and fields without overrides retain their existing type inference.
The five regression cases fail on the original implementation and pass with this fix. The test suite (excluding optional CodSpeed benchmarks), README examples, type/lint checks, and package checks pass on Python 3.14. Independent checks also verified the generated schemas and their validation behavior across dataclass, TypedDict, attrs, Pydantic and Scrapy items.
AI assistance: this change was prepared and checked with OpenAI Codex.