opendht: restore push subscriptions immediately on reconnect#855
Open
pknellore wants to merge 1 commit into
Open
opendht: restore push subscriptions immediately on reconnect#855pknellore wants to merge 1 commit into
pknellore wants to merge 1 commit into
Conversation
When a push notification arrives while the DHT proxy client is Disconnected (e.g. after Android Doze blocks background DNS), arm listenerRestartTimer_ immediately inside pushNotificationReceived() instead of waiting for a successful getProxyInfos() HTTP round-trip. The push itself proves the proxy is reachable. This mirrors what onProxyInfos() does on a Connected transition but avoids the extra network request that fails under Doze/App Standby when DNS is blocked. restartListeners() will resubscribe() all listeners whose opstate->ok is false (marked dead by opFailed()), restoring push subscriptions without any additional HTTP overhead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a push notification arrives while the DHT proxy client is Disconnected (e.g. after Android Doze blocks background DNS), arm listenerRestartTimer_ immediately inside pushNotificationReceived() instead of waiting for a successful getProxyInfos() HTTP round-trip.
The push itself proves the proxy is reachable. This mirrors what onProxyInfos() does on a Connected transition but avoids the extra network request that fails under Doze/App Standby when DNS is blocked.
restartListeners() will resubscribe() all listeners whose opstate->ok is false (marked dead by opFailed()), restoring push subscriptions without any additional HTTP overhead.