Skip to content

Add filter to roll-up previously unrolled documents - #554

Open
palemieux wants to merge 17 commits into
masterfrom
tmp/merge-to-rollup
Open

palemieux wants to merge 17 commits into
masterfrom
tmp/merge-to-rollup

Conversation

@palemieux

Copy link
Copy Markdown
Contributor

Closes #

@jason-valenzuela

Copy link
Copy Markdown

LGTM! Tested the _process_as_rollup clamp fix against some real-world content and it
resolves the drops cleanly.

One of our test files:

WEBVTT

00:00:00.000 --> 00:00:01.600
Good morning everyone and
welcome back to the show

00:00:01.600 --> 00:00:03.200
we have a lot of news
to get through today

converts cleanly to roll-up with the fix applied:

Scenarist_SCC V1.0

00:00:00;00     9426 9426 94ad 94ad 9470 9470 c7ef ef64 206d eff2 6ee9 6e67 20e5 76e5 f279 ef6e e520 616e 6480 ...

00:00:02;09     9426 9426 94ad 94ad 9470 9470 f4ef 2067 e5f4 20f4 68f2 ef75 6768 20f4 ef64 6179

Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants