Adds multithreading support to OSCKit - #28
Open
Daniel-Higgott wants to merge 2 commits into
Open
Daniel-Higgott wants to merge 2 commits into
Daniel-Higgott wants to merge 2 commits into
Conversation
added 2 commits
August 21, 2024 13:25
…hen updating sendingPackets dictionary
…ndition when accessing the sendingPackets dictionary
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses a crash that could occur when sending UDP packets from multiple threads. This fix works by adding a thread lock anytime the framework sends a packet. The thread unlock is deferred until the function falls out of scope.
This commit has been tested and is in use in production with no known issues.