Repository navigation
test(language/lint): add unit tests for expression-validation pass - #90
Merged
monga-puneet merged 1 commit intoOct 9, 2026
Merged
monga-puneet merged 1 commit into
monga-puneet merged 1 commit into
Conversation
monga-puneet
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds unit tests for
packages/language/src/lint/expression-validation.ts, which had no direct tests. 17 tests, following the same pattern as the empty-block (#48) and unreachable-code (#65) tests.Coverage
namespace-function-call) and indirect calls (indirect-function-call)supportedOperatorsfunctionsset@system_variables.uploaded_files: bare dot and bracket references flagged; indexed, sliced andlen()uses allowed; slicing@system_variablesitself flaggedEach test also asserts that the input parsed with no syntax errors, so a grammar change can't make a "no diagnostic" test pass for the wrong reason.
Testing
pnpm vitest runinpackages/language: 30 files, 324 tests pass.