Skip to content

Fix RegisterSyncField(Type, string) to preserve caller targetType (#880) #881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
notfood merged 1 commit into from
Apr 15, 2026
Merged

Fix RegisterSyncField(Type, string) to preserve caller targetType (#880) #881

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions Source/Client/Syncing/Sync.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,24 +57,29 @@ public static SyncField[] Fields(Type targetType, string instancePath, params st

public static ISyncField RegisterSyncField(Type targetType, string fieldName)
{
return RegisterSyncField(AccessTools.Field(targetType, fieldName));
}
FieldInfo field = AccessTools.Field(targetType, fieldName)
?? throw new Exception($"Couldn't find field {targetType}::{fieldName}");

public static ISyncField RegisterSyncField(FieldInfo field)
{
string memberPath = field.ReflectedType + "/" + field.Name;
SyncField sf;
string memberPath;
if (field.IsStatic) {
memberPath = field.ReflectedType + "/" + field.Name;
sf = Field(null, null, memberPath);
} else {
sf = Field(field.ReflectedType, null, field.Name);
memberPath = targetType + "/" + field.Name;
sf = Field(targetType, null, field.Name);
}

registeredSyncFields.Add(memberPath, sf);

return sf;
}

public static ISyncField RegisterSyncField(FieldInfo field)
{
return RegisterSyncField(field.ReflectedType, field.Name);
}

public static SyncDelegate RegisterSyncDelegate(Type inType, string nestedType, string methodName, string[] fields = null, Type[] args = null)
{
string typeName = $"{inType}+{nestedType}";
Expand Down
Loading