Skip to content

Use contribute_arg to handle NoCurrentOp at the top-level - #293

Merged
IsaacWoods merged 1 commit into
rust-osdev:mainfrom
IsaacWoods:main
May 9, 2026
Merged

IsaacWoods merged 1 commit into
rust-osdev:mainfrom
IsaacWoods:main

Conversation

@IsaacWoods

Copy link
Copy Markdown
Member

This makes our arg contribution code more uniform, and as a benefit gracefully handles incorrect Zero and One (as well as other, in theory` opcodes at the top-level. This pattern is seen in the wild fairly often.

Fix #289

This makes our arg contribution code more uniform, and as a benefit gracefully
handles incorrect `Zero` and `One` (as well as other, in theory` opcodes at
the top-level. This pattern is seen in the wild fairly often.
@martin-hughes

Copy link
Copy Markdown
Contributor

Looks good to me - tested and fixes the issue

@IsaacWoods

Copy link
Copy Markdown
Member Author

Lovely, thank you

@IsaacWoods
IsaacWoods merged commit c149532 into rust-osdev:main May 9, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stray One command leads to ParseFail(NoCurrentOp)

2 participants