Fix FreeBSD builds by gating LinkBridgeVlan and Mpls code#162
Conversation
|
@ydirson Could you help me test this PR in FreeBSD in your use environment/CI? |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates conditional compilation attributes to exclude FreeBSD from MPLS-related route building features and restricts the availability of LinkBridgeVlan to specific operating systems. A review comment pointed out a redundant #[cfg] attribute on a method within an implementation block that is already gated by the same condition in src/route/builder.rs.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request updates conditional compilation attributes to exclude MPLS-related route builder functionality on FreeBSD, aligning it with existing exclusions for Android. Additionally, it restricts the export of LinkBridgeVlan to specific platforms (Linux, Fuchsia, and Android) and simplifies pattern matching in traffic control tests by removing unused fields. I have no feedback to provide as there were no review comments.
LinkBridgeVlan was unconditionally imported in lib.rs but only defined on linux/fuchsia/android. Mpls code used AddressFamily::Mpls which doesn't exist on FreeBSD. Added cfg gates to exclude both on FreeBSD. Resolves: rust-netlink#154 Signed-off-by: Gris Ge <cnfourt@gmail.com>
|
@ydirson Could you help me test this PR in FreeBSD in your use environment/CI? |
I'll be able to test next week |
2 participants
LinkBridgeVlan was unconditionally imported in lib.rs but only
defined on linux/fuchsia/android. Mpls code used AddressFamily::Mpls
which doesn't exist on FreeBSD. Added cfg gates to exclude both
on FreeBSD.
Resolves: #154