Create a parse_command function to parse rust-timer commands - #2525
Merged
Conversation
JonathanBrouwer
force-pushed
the
parsing-improvements3
branch
from
August 7, 2026 14:28
d85dd2b to
f08435b
Compare
JonathanBrouwer
force-pushed
the
parsing-improvements3
branch
from
August 10, 2026 08:35
f08435b to
8e3cd23
Compare
Contributor
Author
|
^ Rebased on top of the force pushed main branch to solve conflicts |
JonathanBrouwer
force-pushed
the
parsing-improvements3
branch
from
August 10, 2026 08:41
8e3cd23 to
fca4fe3
Compare
Kobzol
approved these changes
Aug 10, 2026
Kobzol
left a comment
Kobzol
left a comment
Member
There was a problem hiding this comment.
Thank you, this is much more readable than before!
| assert!(parse_build_command("").is_none()); | ||
| fn command_missing() { | ||
| insta::assert_compact_debug_snapshot!(parse_command(""), | ||
| @r#"Err("Cannot find @rust-timer command even though `@rust-timer` is tagged")"#); |
Member
There was a problem hiding this comment.
This error message is misleading, because the test code doesn't have the if condition that gets executed on the live service, but that doesn't matter much.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This separates the parsing code from the logic and makes the tests cover more of the parsing logic.
This is the last refactor to this file for now before I will add new things to it.
I would again recommend enabling "Hide whitespace" while reviewing
r? @Kobzol