Borrowck cleanups part trois - #163357
Open
lqd wants to merge 5 commits into
Open
Borrowck cleanups part trois#163357lqd wants to merge 5 commits into
lqd wants to merge 5 commits into
Conversation
we previously always created an unsolved regioncx to immediately solve it, but can create the solved regioncx in a single step. this is done by merging `UnsolvedRegionInferenceContext`'s `new` and `solve` into one constructor.
rustbot
added
S-waiting-on-review
Member
|
@bors r+ |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed on zulip, this followup to #163266 contains a few cleanups (and much like the Godfather Trilogy, the 3rd one is not as good as the previous 2):
newandsolvefunctions into a uniqueRegionInferenceContext::solveentry point, because it was indeed funny to only do both of these together. This is the biggest change in the PR but is mostly moving these two functions' code into one, and renamingself3 or 4 times at most.This makes me realize we surely broke some tiny parts of consumers.rs in the previous (because functions that were pub are now pub(crate)) but since we don't know what they're used for, on the immutable or mutable regioncx, it's impossible to know how to fix until the consumers tell us. It's fine.
r? @jackh726