Move #[naked] attribute check to attribute parsing stage by RichardTjokroutomo · Pull Request #162530 · rust-lang/rust

RichardTjokroutomo · 2026-09-09T12:24:57Z

Following #161482's idea to add target_item field to FinalizeCheckContext, replace target_item with ast_target, which is an enum that contains all possible types of target Item (obtained by grepping all functions that call lower_attrs()).

This change is needed as methods defined under traits & impls are represented as ast::AssocItem. Lastly, move check_naked to the callback returned by NakedParser::deferred_finalize_check().

Part of #153101. r?@JonathanBrouwer

LLM disclosure: I wrote the code by hand & took inspiration from #161482. However, I did use LLM to learn how attribute checking is done in Rustc.

rustbot · 2026-09-09T12:25:00Z

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann, @JonathanBrouwer

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann, @JonathanBrouwer

rustbot · 2026-09-09T12:25:04Z

Thanks for the pull request, and welcome! The Rust Project has assigned @nnethercote (or someone else) to review your changes, you should hear from them (or someone else) within the next two weeks.

Please see the contribution instructions and our LLM policy for more information.

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler
compiler expanded to 76 candidates
Random selection from 22 candidates

JonathanBrouwer · 2026-09-11T09:10:51Z

+                    };
+
+                    let ItemKind::Fn(fn_item) = &item.kind else {
+                        return;


This should never fail right? So please make this panic

View changes since the review

After implementing panic, through the failing CI I just found out that methods defined under traits & impls are represented as associated item instead of normal item.... lucky...

JonathanBrouwer · 2026-09-11T09:11:12Z

+                    MethodKind::Trait { body: true } | MethodKind::TraitImpl | MethodKind::Inherent,
+                ) => {
+                    let Some(item) = cx.target_item else {
+                        return;


same with this

View changes since the review

JonathanBrouwer · 2026-09-11T09:15:02Z

+    /// - support unwinding with `-Cpanic=unwind`, unlike `extern "C"`
+    /// - often diverge from the C ABI
+    /// - are subject to change between compiler versions
+    pub fn is_rustic_abi(self) -> bool {


Can we avoid duplicating this logic?
Perhaps by parsing the abi into a ExternAbi instead?

View changes since the review

I don't think we can. I originally tried to convert it to ExternAbi, but I couldn't compile as it creates circular dependency (haven't checked deeper as to why, though).

Then I saw similar check for CanonAbi, and I thought since the logic is already duplicated elsewhere, perhaps I can also add similar method to Extern.

I'll doubly insist that this logic should not be duplicated.

OK; I added a helper method to convert extern to externAbi

rustbot · 2026-09-11T09:15:31Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

rustbot · 2026-09-13T02:17:48Z

Some changes occurred in compiler/rustc_attr_ir

cc @jdonszelmann, @JonathanBrouwer

RichardTjokroutomo · 2026-09-13T14:33:39Z

@rustbot ready

rustbot · 2026-09-15T16:40:37Z

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

Signed-off-by: Richard Tjokroutomo <richard.tjokro2@gmail.com>

rustbot · 2026-09-19T12:46:20Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

…functions calling lower_attrs() Signed-off-by: Richard Tjokroutomo <richard.tjokro2@gmail.com>

rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 9, 2026

rustbot assigned nnethercote Sep 9, 2026

RichardTjokroutomo force-pushed the check-attr-naked branch from 57ae8f4 to c65aa6f Compare September 9, 2026 12:26

rustbot assigned JonathanBrouwer and unassigned nnethercote Sep 9, 2026

This comment has been minimized.

Sign in to view

RichardTjokroutomo force-pushed the check-attr-naked branch from c65aa6f to 4c2e629 Compare September 9, 2026 13:43

This comment has been minimized.

Sign in to view

RichardTjokroutomo force-pushed the check-attr-naked branch from 4c2e629 to ee7a87a Compare September 9, 2026 13:48

RichardTjokroutomo changed the title ~~move check_naked() from check_attr.rs to codegen_attrs.rs~~ Move #[naked] attribute check to attribute parsing stage Sep 10, 2026

RichardTjokroutomo force-pushed the check-attr-naked branch from ee7a87a to 9d144c2 Compare September 10, 2026 06:56

This comment has been minimized.

Sign in to view

JonathanBrouwer reviewed Sep 11, 2026

View reviewed changes

Comment thread compiler/rustc_ast_lowering/src/lib.rs Outdated

JonathanBrouwer requested changes Sep 11, 2026

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 11, 2026

RichardTjokroutomo force-pushed the check-attr-naked branch from 9d144c2 to 7e93b9a Compare September 11, 2026 12:00

This comment has been minimized.

Sign in to view

RichardTjokroutomo force-pushed the check-attr-naked branch from 7e93b9a to cdc980c Compare September 11, 2026 13:49

This comment has been minimized.

Sign in to view

RichardTjokroutomo force-pushed the check-attr-naked branch from cdc980c to 4fbadae Compare September 11, 2026 13:57

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 12, 2026

This comment has been minimized.

Sign in to view

RichardTjokroutomo force-pushed the check-attr-naked branch from 8698b20 to 8969f45 Compare September 13, 2026 02:53

This comment has been minimized.

Sign in to view

RichardTjokroutomo force-pushed the check-attr-naked branch from 8969f45 to 1486a1f Compare September 13, 2026 04:04

This comment has been minimized.

Sign in to view

RichardTjokroutomo force-pushed the check-attr-naked branch from 1486a1f to 2891b61 Compare September 13, 2026 13:11

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 13, 2026

RichardTjokroutomo requested a review from mejrs September 13, 2026 14:33

This comment has been minimized.

Sign in to view

RichardTjokroutomo force-pushed the check-attr-naked branch from fd6559e to d041737 Compare September 15, 2026 16:51

This comment has been minimized.

Sign in to view

RichardTjokroutomo force-pushed the check-attr-naked branch from d041737 to 7d02364 Compare September 16, 2026 06:25

This comment has been minimized.

Sign in to view

obeis mentioned this pull request Sep 17, 2026

Use attribute parser for checking #[may_dangle] attribute #162886

Open

This comment has been minimized.

Sign in to view

RichardTjokroutomo added 4 commits September 19, 2026 20:18

move check_naked() from check_attr.rs to codegen_attrs.rs

17410f6

Signed-off-by: Richard Tjokroutomo <richard.tjokro2@gmail.com>

also consider associate item

e0a0466

Signed-off-by: Richard Tjokroutomo <richard.tjokro2@gmail.com>

wrap target_item & target_assoc_item into an enum

5868934

Signed-off-by: Richard Tjokroutomo <richard.tjokro2@gmail.com>

addressing review comments

e26e101

Signed-off-by: Richard Tjokroutomo <richard.tjokro2@gmail.com>

RichardTjokroutomo force-pushed the check-attr-naked branch from 7d02364 to 05aa3f9 Compare September 19, 2026 12:46

This comment has been minimized.

Sign in to view

exhaust all possible types of AST Target (obtained from grepping all …

2e27ca7

…functions calling lower_attrs() Signed-off-by: Richard Tjokroutomo <richard.tjokro2@gmail.com>

RichardTjokroutomo force-pushed the check-attr-naked branch from 05aa3f9 to 2e27ca7 Compare September 19, 2026 13:17

Uh oh!

Conversation

RichardTjokroutomo commented Sep 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Sep 9, 2026

Uh oh!

rustbot commented Sep 9, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

JonathanBrouwer Sep 11, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

RichardTjokroutomo Sep 11, 2026

Choose a reason for hiding this comment

Uh oh!

JonathanBrouwer Sep 11, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JonathanBrouwer Sep 11, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

RichardTjokroutomo Sep 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mejrs Sep 12, 2026

Choose a reason for hiding this comment

Uh oh!

RichardTjokroutomo Sep 13, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rustbot commented Sep 11, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rustbot commented Sep 13, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

RichardTjokroutomo commented Sep 13, 2026

Uh oh!

rustbot commented Sep 15, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rustbot commented Sep 19, 2026

Uh oh!

This comment has been minimized.

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

RichardTjokroutomo commented Sep 9, 2026 •

edited

Loading

JonathanBrouwer Sep 11, 2026 •

edited by rustbot

Loading

JonathanBrouwer Sep 11, 2026 •

edited by rustbot

Loading

JonathanBrouwer Sep 11, 2026 •

edited by rustbot

Loading

RichardTjokroutomo Sep 11, 2026 •

edited

Loading