Rollup of 6 pull requests - #161688
Closed
JonathanBrouwer wants to merge 37 commits into
Closed
Conversation
The linker used by MinGW now works with ar_archive_writer generated short import libraries too.
LLVM 24 stopped using llvm::Any here to avoid heap allocations in PassInstrumentation.
The essential problem is that, with this table: ```text one | ----| a | b | c a | b | a | b a | ``` And this logic: ```rust let too_many_pipes = divider_count > expected_cells + 1; ``` `expected_cells + 1` winds up as 2, so you get this warning: ```text error: unused content after last table cell --> $DIR/invalid_markdown_table.rs:81:14 | LL | //! a | b | c | ^^^^^^ this content is discarded error: unused content after last table cell --> $DIR/invalid_markdown_table.rs:83:14 | LL | //! a | b | | ^^^^ this content is discarded error: unused content after last table cell --> $DIR/invalid_markdown_table.rs:85:14 | LL | //! a | b | ^^ this content is discarded ``` We really want our warning to give the suggest-escaping flow, like this: ```text error: table row has too many columns --> $DIR/invalid_markdown_table.rs:81:13 | LL | //! a | b | c | ^ any content after this column divider is discarded | = help: to escape `|` characters in tables, add a `\` before them like `\|` error: table row has too many columns --> $DIR/invalid_markdown_table.rs:83:13 | LL | //! a | b | | ^ any content after this column divider is discarded | = help: to escape `|` characters in tables, add a `\` before them like `\|` error: unused content after last table cell --> $DIR/invalid_markdown_table.rs:85:14 | LL | //! a | b | ^^ this content is discarded ``` By only scanning the text between the end of the last cell and the row, instead of doing the entire row, we don't have to re-implement as much of pulldown-cmark's logic.
The reason `rustc_ast_ir` and `rustc_pattern_analysis` have nested `cfg_attr`s is so that they don't mention `cfg(bootstrap)` when nightly or rustc cargo feature turned on. If you don't do it like that, they stop compiling on stable (or rather, they emit unexpected cfg warnings...).
??? why wasn't this detected by compiletest ???
rustbot
added
T-libs
Member
Author
|
@bors r+ p=5 |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 24, 2026
…uwer Rollup of 6 pull requests Successful merges: - #155499 (stabilize never type) - #161294 (add crashtests [6/N]) - #161050 (Only use dlltool.exe on MinGW if -Cdlltool is passed) - #159583 (Add new `invalid_markdown_table` rustdoc lint) - #161098 (PassWrapper: handle LLVM 24 change in function types) - #161661 (Don't treat slashes as path seps after drive letters in verbatim paths)
rust-bors
Bot
added
S-waiting-on-review
Contributor
|
💔 Test for e39bcc1 failed: CI. Failed job:
|
Member
Author
|
@bors try jobs=dist-i686-mingw |
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 24, 2026
Rollup of 6 pull requests try-job: dist-i686-mingw
Contributor
|
I don't see how my 1 line change to the sys module of windows could have caused a linker error but I'm open to surprises |
Member
Author
|
Yeah I wasn't sure which PR caused this so I just started a try job on all of them :p |
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Member
|
As you already guessed #161050 is likely the reason for it. |
Contributor
|
How did you conclude that? ^^ |
rust-bors
Bot
added
S-waiting-on-author
Contributor
|
PR #161050, which is a member of this rollup, was unapproved. |
Contributor
|
💔 Test for 16088f9 failed: CI. Failed job:
|
rustbot
removed
the
S-waiting-on-author
Member
From the log of the previous failed build. |
Contributor
|
I was being sarcastic :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
invalid_markdown_tablerustdoc lint #159583 (Add newinvalid_markdown_tablerustdoc lint)r? @ghost
Create a similar rollup