buffer swap optimization on type inference - #23341
Closed
CosmicalBit wants to merge 1 commit into
Closed
CosmicalBit wants to merge 1 commit into
CosmicalBit wants to merge 1 commit into
Conversation
CosmicalBit
marked this pull request as ready for review
September 10, 2026 10:47
Contributor
|
First, we're about to share this code with rustc, so we won't change it. Second, the entire point is to reuse the allocation. Also the N here is usually small. |
Contributor
|
Thank you for your interest in contributing anyway! |
Author
Thanks 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoids moving pending obligations element by element into the scratch buffer. Swaps the two Vecs instead, turning the transfer from O(n) into O(1).