fix: Do not fill unstable methods in "Implement default members" - #23318
Open
ChayimFriedman2 wants to merge 1 commit into
Open
fix: Do not fill unstable methods in "Implement default members"#23318ChayimFriedman2 wants to merge 1 commit into
ChayimFriedman2 wants to merge 1 commit into
Conversation
But do in "Implement missing members", or if the feature is enabled, or if the trait has the same feature, since it is likely to be enabled by the user. We could choose another way, to do what we do in completion: consider all non-internal features available on any nightly toolchain. However here I find this method better, since we implement many methods at once.
rustbot
added
the
S-waiting-on-review
A4-Tacks
approved these changes
Sep 11, 2026
Member
There was a problem hiding this comment.
LGTM
BTW, Compared to this, #23066 is more complicated, rewriting unstable syntax in stable functions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
But do in "Implement missing members", or if the feature is enabled, or if the trait has the same feature, since it is likely to be enabled by the user.
We could choose another way, to do what we do in completion: consider all non-internal features available on any nightly toolchain. However here I find this method better, since we implement many methods at once.