internal: Do not the same types twice in hir-ty lowering - #23196
Open
ChayimFriedman2 wants to merge 2 commits into
Open
internal: Do not the same types twice in hir-ty lowering#23196ChayimFriedman2 wants to merge 2 commits into
ChayimFriedman2 wants to merge 2 commits into
Conversation
Again for the intent of making `AnonConst` a tracked struct (as well as for perf). We still have one problematic query: `resolve_type_param_assoc_type_shorthand()`. It is problematic and I need to think what to do with it.
E.g.:
```rust
trait Trait
where
Self::Assoc: OtherTrait,
{
type Assoc;
}
```
Is equivalent to:
```rust
trait Trait {
type Assoc: OtherTrait;
}
```
The code was copied from rustc and adapted.
rustbot
added
the
S-waiting-on-review
Veykril
reviewed
Sep 6, 2026
Comment on lines
+275
to
+281
| impl<'db> Default for Clauses<'db> { | ||
| #[inline] | ||
| fn default() -> Self { | ||
| Clauses::empty(DbInterner::conjure()) | ||
| } | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
Do we have to add this? I'd prefer not to ideally conjure shouldn't exist in the first place, so I'd rather remove uses of it than add them
Contributor
Author
There was a problem hiding this comment.
I don't like conjure() too much but I wouldn't want to complicate the API just to avoid it.
Alternatively, we don't really need the database in order to intern and only do that for API reasons. We can avoid that and probably get rid of conjure() completely.
| pub fn get(&self, local_id: LocalTypeOrConstParamId) -> Ty<'_> { | ||
| match self.map.get(local_id) { | ||
| Some(ty) => ty.as_ref(), | ||
| None => Ty::new_error(DbInterner::conjure(), ErrorGuaranteed), |
Member
There was a problem hiding this comment.
likewise threading the database through here shouldn't be much work
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Again for the intent of making
AnonConsta tracked struct (as well as for perf).We still have one problematic query:
resolve_type_param_assoc_type_shorthand(). It is problematic and I need to think what to do with it.And a drive-by fix in the second commit.
Best reviewed commit by commit. The commits are fully separate.