Repository navigation
PhantomData: clearly document alignment of 1, add to glossary examples - #2375
Merged
Merged
Conversation
rustbot
added
the
S-waiting-on-review
DanielEScherzer
force-pushed
the
phantomdata-1-zst
branch
from
October 4, 2026 23:18
4682844 to
d0f640d
Compare
Contributor
Author
|
Guarantees were added in rust-lang/rust#104081 after going through FCP by T-libs-api (back when that team existed), so this shouldn't be adding any new guarantees (impossible to have an alignment of less than 1, so 1 is the minimum that was previously documented) |
DanielEScherzer
changed the title
traviscross
reviewed
Oct 6, 2026
DanielEScherzer
force-pushed
the
phantomdata-1-zst
branch
from
October 6, 2026 18:47
d0f640d to
f658cfb
Compare
Test that PhantomData around a ZST and around a non-zero-sized non-1-aligned type are both considered ZSTs.
Test that PhantomData around a 1-ZST and around a non-zero-sized non-1-aligned type are both considered 1-ZSTs.
DanielEScherzer
force-pushed
the
phantomdata-1-zst
branch
from
October 6, 2026 18:51
f658cfb to
243849f
Compare
traviscross
approved these changes
Oct 6, 2026
Contributor
|
Thanks @DanielEScherzer. |
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.