update tracing log format, remove unnessary rustwide log fields - #3498
Merged
Conversation
syphar
marked this pull request as ready for review
September 3, 2026 17:28
This comment has been minimized.
This comment has been minimized.
Member
Author
|
Damn, some compile errors / test errors. Will fix them tomorrow or later or next week, then ping you again |
syphar
force-pushed
the
simpl-log
branch
2 times, most recently
from
September 4, 2026 07:11
d1b35cd to
beebb75
Compare
syphar
marked this pull request as draft
September 4, 2026 08:30
syphar
marked this pull request as ready for review
September 7, 2026 09:39
Member
Author
GuillaumeGomez
approved these changes
Sep 7, 2026
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prettyformat used the tracing-subscriberFullformat, which is quite noisy.tracing-subscribersupports by default.compactwill be the default, which puts the msg/span fields at the endis_terminalor not. So we can drop the explicit setting on our server, and will have nicers logs indocs_rs_admin, or other CLI calls.rustwidebuild logs came viatracing_log::LogTracer, which appended 4 additional fields to each line. We don't need most of these, so I added a custom adapter that will just emit the log-message and target to tracing, and drop the rest. This only affects tests, local CLI / dev usage, etc. On our production build-servers, the log-tracer was disabled anyways, since we don't emit the build logs, just capture and upload them. But: this will be much more interesting when the build-cli for CI makes progress, so the output is actually usable.next steps after this
INFOtoDEBUGfor some spans (for example internal function calls in rustwide)instrument(skip_all)), only add back what we really want to see in the logs, and never use the debug representation of structs in logs.tracing log format
With an active
build{crate=example}span, the previous full formatterrepeated the span fields before each bridged message:
The compact formatter keeps the span name before the message and appends
the span fields after it: