Skip to content

remove obsolete "releases.downloads" field #3488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
syphar merged 1 commit into from
Aug 31, 2026
Merged

remove obsolete "releases.downloads" field #3488

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions ...f8d6755d85d4bde1de74f4335ff8b31109ed.json → ...4a95de28b3a999796dfa558a6fcc045e1ebc.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 6 additions & 6 deletions ...23b4bd53b41a30799988f7f498a891115a0d.json → ...5aafa70cdd81877373bdfab344d86e3884e9.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions crates/bin/docs_rs_builder/src/docbuilder/rustwide_builder.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2419,8 +2419,8 @@ mod tests {
let row = block_on_async_with_conn!(env, |mut conn| async {
sqlx::query!(
r#"SELECT
c.name,
r.version,
c.name as "name!",
r.version as "version!",
r.rustdoc_status,
cov.total_items
FROM
Expand Down Expand Up @@ -2479,8 +2479,8 @@ mod tests {
let row = block_on_async_with_conn!(env, |mut conn| async {
sqlx::query!(
r#"SELECT
c.name,
r.version,
c.name as "name!",
r.version as "version!",
r.rustdoc_status,
cov.total_items
FROM
Expand Down
2 changes: 2 additions & 0 deletions crates/lib/docs_rs_database/migrations/20260831124612_remove-release-downloads.down.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
ALTER TABLE releases
ADD COLUMN downloads INTEGER;
1 change: 1 addition & 0 deletions crates/lib/docs_rs_database/migrations/20260831124612_remove-release-downloads.up.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
ALTER TABLE releases DROP COLUMN downloads;
16 changes: 7 additions & 9 deletions crates/lib/docs_rs_database/src/releases.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,14 +66,13 @@ pub async fn finish_release(
readme = $13,
keywords = $14,
have_examples = $15,
downloads = $16,
doc_targets = $17,
is_library = $18,
documentation_url = $19,
default_target = $20,
features = $21,
repository_id = $22,
source_size = $23
doc_targets = $16,
is_library = $17,
documentation_url = $18,
default_target = $19,
features = $20,
repository_id = $21,
source_size = $22
WHERE id = $1"#,
release_id.0,
registry_data.release_time,
Expand All @@ -90,7 +89,6 @@ pub async fn finish_release(
readme,
serde_json::to_value(&metadata_pkg.keywords)?,
has_examples,
registry_data.downloads,
serde_json::to_value(doc_targets)?,
is_library,
metadata_pkg.documentation,
Expand Down
7 changes: 0 additions & 7 deletions crates/lib/docs_rs_registry_api/src/api.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,8 +126,6 @@ impl RegistryApi {
created_at: DateTime<Utc>,
#[serde(default)]
yanked: bool,
#[serde(default)]
downloads: i32,
}

let response: Response = match self.request(&url).await {
Expand All @@ -147,7 +145,6 @@ impl RegistryApi {
Ok(Some(ReleaseData {
release_time: version.created_at,
yanked: version.yanked,
downloads: version.downloads,
}))
}

Expand Down Expand Up @@ -430,13 +427,11 @@ mod tests {
"num": V1.to_string(),
"created_at": "2024-01-01T00:00:00Z",
"yanked": false,
"downloads": 42
},
{
"num": V2.to_string(),
"created_at": "2024-01-02T00:00:00Z",
"yanked": true,
"downloads": 100
}
]
}),
Expand All @@ -452,7 +447,6 @@ mod tests {
.unwrap()
.with_timezone(&Utc),
yanked: false,
downloads: 42,
}
);

Expand Down Expand Up @@ -487,7 +481,6 @@ mod tests {
"num": V1.to_string(),
"created_at": "2024-01-01T00:00:00Z",
"yanked": false,
"downloads": 42
}
]
}),
Expand Down
2 changes: 0 additions & 2 deletions crates/lib/docs_rs_registry_api/src/models.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,15 +12,13 @@ pub struct CrateData {
pub struct ReleaseData {
pub release_time: DateTime<Utc>,
pub yanked: bool,
pub downloads: i32,
}

impl Default for ReleaseData {
fn default() -> ReleaseData {
ReleaseData {
release_time: Utc::now(),
yanked: false,
downloads: 0,
}
}
}
Expand Down
1 change: 0 additions & 1 deletion crates/lib/docs_rs_test_fakes/src/legacy.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,6 @@ impl<'a> FakeRelease<'a> {
registry_release_data: ReleaseData {
release_time: Utc::now(),
yanked: false,
downloads: 0,
},
has_docs: true,
has_examples: false,
Expand Down
Loading