CSS variables for web templates - #866
clarfonthey wants to merge 1 commit into
Conversation
|
Since I should have looked at issues first, cc #832. |
There was a problem hiding this comment.
Hi, Jakub mentioned this issue and that I should take a look at it.
It's definitely a good idea to merge the various colors into variables to be easily changed later.
I will test this out soon, for now I just wanted to leave this comment and also point out that we will be using the Vue framework for the bors queue page (it's something I'm starting to work on now). Part of that migration will be also to have a dark mode (as you've seen in the issue link).
Will 'approve' as soon as I get to my proper PC to see things better :D
|
All good, I'm mostly trying to find a way to make things better with minimal changes in the meantime. And, well, I guess you can yoink the colour choices too. |
This branch has not been deployed
2 participants
Kind of doing this out of spite and annoyance at the queue page flashbanging me and wanting to implement dark mode, but, 100% only going to implement it as a proper solution that honours system settings.
So, to initiate that, starting by refactoring the existing CSS to use variables which can be fixed later. Also fixing up a few oddities with the current CSS, like the border around the docs next to the rollup statuses not being the same as the text colour.
That last point being basically the only place where it will be observable.
Note this won't make it trivial to change the colours to use
light-darkimmediately, but, hopefully this is 90% of what we need and okay to merge as-is for now so that it's testable more easily on the live queue with actual data.