Wait for cargo fmt - #451
Merged
Merged
Conversation
Collaborator
|
Thanks for contributing to formality! :) |
Member
|
#448 also does this |
Member
Author
Oh, I hadn't seen that, thanks! They might have run into the same issue too. Not sure how long it'll take to merge, though. Maybe we can go with this for now so other prs don't hit the same issue. I am also fine with closing this. 🙂 |
Member
|
Yeah, with the holidays and all, that other PR will likely not be merged soon and can be rebased later, let's go with this one then! |
lqd
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
I have been seeing CI failures on another PR of mine: https://github.com/rust-lang/a-mir-formality/actions/runs/31603415405, which seem to be caused by deferred formatting. We used to spawn
fmt, so it would run in the background, but now we wait forfmtto finish before doing anything else.How does it work, what questions do you have?
AI disclosure