Skip to content

Wait for cargo fmt - #451

Merged
lqd merged 1 commit into
rust-lang:mainfrom
bit-aloo:2026-08-12-status-instead-of-spawn
Aug 12, 2026
Merged

Wait for cargo fmt#451
lqd merged 1 commit into
rust-lang:mainfrom
bit-aloo:2026-08-12-status-instead-of-spawn

Conversation

@bit-aloo

Copy link
Copy Markdown
Member

What does this PR do?

I have been seeing CI failures on another PR of mine: https://github.com/rust-lang/a-mir-formality/actions/runs/31603415405, which seem to be caused by deferred formatting. We used to spawn fmt, so it would run in the background, but now we wait for fmt to finish before doing anything else.

How does it work, what questions do you have?

AI disclosure

  • I did not use any AI tools

@rustbot

rustbot commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator

Thanks for contributing to formality! :)
A reviewer will take a look at your PR within a week or two. If not, come talk to us on https://rust-lang.zulipchat.com/#narrow/channel/402470-t-types.2Fformality

@lqd

lqd commented Aug 12, 2026

Copy link
Copy Markdown
Member

#448 also does this

@bit-aloo

Copy link
Copy Markdown
Member Author

#448 also does this

Oh, I hadn't seen that, thanks! They might have run into the same issue too.

Not sure how long it'll take to merge, though. Maybe we can go with this for now so other prs don't hit the same issue. I am also fine with closing this. 🙂

@lqd

lqd commented Aug 12, 2026

Copy link
Copy Markdown
Member

Yeah, with the holidays and all, that other PR will likely not be merged soon and can be rebased later, let's go with this one then!

@lqd
lqd added this pull request to the merge queue Aug 12, 2026
Merged via the queue into rust-lang:main with commit 5a8c8f7 Aug 12, 2026
5 checks passed
@bit-aloo
bit-aloo deleted the 2026-08-12-status-instead-of-spawn branch August 12, 2026 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants