Check for duplicate trait impl item - #447
Merged
tiif merged 2 commits intoAug 22, 2026
Merged
Conversation
Collaborator
|
Thanks for contributing to formality! :) |
tiif
requested changes
Aug 12, 2026
Member
There was a problem hiding this comment.
Thanks! Other than the nits, the rest are fine to me.
(the fmt in my suggestion is off, you will need to run cargo fmt after applying the change)
View changes since this review
bit-aloo
force-pushed
the
2026-08-07-check-for-duplicate-trait-impl-item
branch
2 times, most recently
from
August 12, 2026 13:25
b2b852f to
86453cb
Compare
bit-aloo
force-pushed
the
2026-08-07-check-for-duplicate-trait-impl-item
branch
from
August 12, 2026 13:31
86453cb to
a0ef5dd
Compare
bit-aloo
force-pushed
the
2026-08-07-check-for-duplicate-trait-impl-item
branch
from
August 12, 2026 13:49
a0ef5dd to
7e55561
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
bit-aloo
force-pushed
the
2026-08-07-check-for-duplicate-trait-impl-item
branch
from
August 12, 2026 14:29
7e55561 to
46d9387
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We didn't had any check for duplicate trait impl item. This PR adds that. I am currently working through #419, and going across all checks to understand better. I believe there might be more such cases, I will try to spot more.
AI disclosure