Repository navigation
feat: add optional scene detection cancellation - #219
Merged
Merged
Conversation
Contributor
Author
|
I just realized I could perhaps add CTRL+C handling in |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #219 +/- ##
==========================================
- Coverage 26.01% 25.97% -0.05%
==========================================
Files 31 31
Lines 3029 3034 +5
==========================================
Hits 788 788
- Misses 2241 2246 +5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
shssoichiro
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an optional
AtomicBoolparameter todetect_scene_changes()that can be set totrueby the caller at any time to cancel scene detection.Without this the only way to "cancel" scene detection is to exit the program entirely which is at best not graceful and at worst unacceptable for interactive applications.
Example
Thanks,
- Boats M.