Repository navigation
Add FFMS2 indexing options - #19
Merged
Merged
Conversation
shssoichiro
reviewed
Oct 20, 2026
shssoichiro
reviewed
Oct 20, 2026
Fix FFMS2 indexing progress logic is duplicated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
with_indexfunction to the FFMS2 Decoder to allow users to define their own index path and get progress feedback on indexing. Additionalbuild_indexfunction allows users to index with progress and the ability to cancel indexing without having to instantiate a decoder.Progress is represented as a percentage rather than bytes read for simplicity and always start with 0 and ends with 100, even if it hits cache and indexing technically did not occur.
Also adds getters for downstream users to access the decoder's video index, the path to the video, and the path to the index.
Changelog is under 0.12.0 instead of 0.11.2 as I wrote this after a different PR which requires a minor update and I don't expect a version 0.11.2 release just for this PR.
Note
Nearly all of the changes are LLM-generated.
Thanks,
- Boats M.