Add govulncheck to CI#55
Closed
AviadHayumi wants to merge 3 commits into
Closed
Conversation
Restructures the single-job CI into parallel lint/validate/test/helm/actionlint jobs with a CI Summary aggregator suitable for branch-protection. Adds race detector + coverage on test, Codecov upload, concurrency cancel-in-progress, and pulls Go version from go.mod. Also adds: - govulncheck nightly + on go.mod change - dependency-review on PRs - OSSF Scorecard weekly - CodeQL on PRs and weekly - govulncheck and test-cover make targets - Friendlier error message when generated files drift Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> Signed-off-by: aviadh <aviad.hayumi@gmail.com>
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
Fixes two SC2086 findings surfaced by actionlint+shellcheck on the new CI. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> Signed-off-by: aviadh <aviad.hayumi@gmail.com>
Drop the parallel-job split, codeql, scorecard, dependency-review and separate govulncheck workflow. Karta is a Go library + helm chart, so keep CI to one job. Net change vs main: govulncheck step + concurrency cancel-in-progress + sourcing Go version from go.mod. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> Signed-off-by: aviadh <aviad.hayumi@gmail.com>
AviadHayumi
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds
govulncheckto CI so vulnerable dependencies fail the build, plus two small drive-bys:concurrency.cancel-in-progress— superseded PR commits stop running.go.mod(go-version-file) instead of the hard-coded1.25.7, which had drifted behindgo.mod's1.25.9.make checkalready covered lint + test. Newmake govulnchecktarget installsgolang.org/x/vuln/cmd/govulncheckintobin/and scans./..., mirroring the existing tool-bootstrap pattern.Related issue(s)
Fixes #
Checklist
git commit -s)make check)