Skip to content

Add slinky.slurm.net/v1beta1 NodeSet Karta sample#126

Open
YuuGR1337 wants to merge 1 commit into
run-ai:mainfrom
YuuGR1337:fix/issue-115
Open

Add slinky.slurm.net/v1beta1 NodeSet Karta sample#126
YuuGR1337 wants to merge 1 commit into
run-ai:mainfrom
YuuGR1337:fix/issue-115

Conversation

@YuuGR1337

@YuuGR1337 YuuGR1337 commented Jun 30, 2026

Copy link
Copy Markdown

Fixes #115


Summary by CodeRabbit

  • Documentation
    • Added a new sample entry for Slinky NodeSet Karta definitions.
    • Included a link to the sample YAML and referenced the relevant API group.

Closes run-ai#115

Signed-off-by: YuuGR1337 <yudhatamvan25@gmail.com>
@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: 82404ce1-86bc-41f9-bb45-dc477b5c643b

📥 Commits

Reviewing files that changed from the base of the PR and between 143e7ae and 81f3fda.

📒 Files selected for processing (1)
  • README.md

Walkthrough

A single documentation bullet is added to README.md linking to docs/samples/nodeset.yaml with a reference to the slinky.slurm.net/v1beta1 API group for the Slinky NodeSet sample Karta definition.

Changes

README Documentation Entry

Layer / File(s) Summary
README Slinky NodeSet bullet
README.md
Adds one list item under the Documentation section pointing to docs/samples/nodeset.yaml and noting the slinky.slurm.net/v1beta1 API group.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A bunny hops through docs so neat,
One line to make the sample complete,
NodeSet lands with slurmd pods in rows,
slinky.slurm.net — off it goes!
🐇✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Linked Issues check ⚠️ Warning The PR only adds a README link and does not add the requested docs/samples/nodeset.yaml Karta sample. Add the NodeSet Karta sample in docs/samples/nodeset.yaml with the required apiVersion, kind, pod template, replicas, selector, and status mappings.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the requested NodeSet Karta sample addition.
Out of Scope Changes check ✅ Passed The README link update is directly related to the requested NodeSet sample and appears in scope.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@Isan-Rivkin Isan-Rivkin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @YuuGR1337 ty for submitting a PR.
It no ready for review (no nodeset, link broken).
Please share some context and fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add slinky.slurm.net/v1beta1 NodeSet Karta sample

2 participants