Skip to content

avm2: Check allowNetworking in fscommand - #25129

Open
evilpie wants to merge 2 commits into
ruffle-rs:masterfrom
evilpie:fscommand
Open

avm2: Check allowNetworking in fscommand#25129
evilpie wants to merge 2 commits into
ruffle-rs:masterfrom
evilpie:fscommand

Conversation

@evilpie

@evilpie evilpie commented Nov 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Description

Seems like they forgot to use the error for allowNetworking here and accidentally used the error meant for allowScriptAccess.

Testing

Adds a test.

Checklist

  • I, a human, have self-reviewed this PR and fully understand the changes within.
  • I have made or updated tests where possible.
  • All of my commits are properly scoped, compile successfully, and pass all tests.
  • This PR does not make sense to split up into smaller PRs.
  • An LLM was involved in the authoring of this code.

@evilpie evilpie added A-avm2 Area: AVM2 (ActionScript 3) T-compat Type: Compatibility with Flash Player labels Nov 7, 2026
kjarosh
kjarosh reviewed Nov 7, 2026
View reviewed changes
Comment thread tests/tests/swfs/avm2/allow_networking/Test.as Resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kjarosh kjarosh kjarosh left review comments

Assignees

No one assigned

Labels

A-avm2 Area: AVM2 (ActionScript 3) T-compat Type: Compatibility with Flash Player

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@evilpie @kjarosh