Repository navigation
core/avm1/avm2: Remove avm_debug - #25126
Open
Lord-McSweeney wants to merge 4 commits into
Open
Lord-McSweeney wants to merge 4 commits into
Lord-McSweeney wants to merge 4 commits into
Conversation
Lord-McSweeney
added
A-core
Collaborator
|
I think this is a good idea, this was never useful to me either. Please also update the CONTRIBUTING.md: https://github.com/ruffle-rs/ruffle/blob/master/CONTRIBUTING.md#debugging-actionscript-content. |
…exceptions The `avm_debug` features in AVM2 were not very useful as they were, due to the verbosity of the output. This commit removes all of them except for support for logging caught exceptions, which can still useful.
We already have good support for debugging through the desktop Debug Tools. Logging of caught exceptions is now the only remaining avm_debug- specific feature.
The only remaining use of this feature was for logging AVM2 caught exceptions. In the future, I plan to add more AVM2 debugging and profiling support using this feature.
Lord-McSweeney
force-pushed
the
debug-refactor
branch
from
November 8, 2026 00:54
bc0fff7 to
8902f68
Compare
evilpie
reviewed
Nov 8, 2026
evilpie
approved these changes
Nov 8, 2026
kjarosh
approved these changes
Nov 8, 2026
Remove references to `avm_debug`.
Lord-McSweeney
force-pushed
the
debug-refactor
branch
from
November 8, 2026 17:32
8902f68 to
da2baa1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This feature was useful in the past, but we now have the Debug Tools in desktop Ruffle, which are much more comprehensive and easy to use.
avm_debugsupport was a source of maintenance burden for us: for example, it required us to handleOp::Debugin AVM2.Testing
No functional changes (unless you're compiling with
avm_debug)Checklist