Skip to content

naga-agal: Fix single-component write mask reading wrong source component - #25098

Open
pngdrift wants to merge 2 commits into
ruffle-rs:masterfrom
pngdrift:agal-single-component-write-mask
Open

pngdrift wants to merge 2 commits into
ruffle-rs:masterfrom
pngdrift:agal-single-component-write-mask

Conversation

@pngdrift

@pngdrift pngdrift commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Description

Fixes single-component destination writes in AGAL shaders reading the wrong component of the source.

Testing

I added stage3d/agal_single_component_write_mask test. Also naga-agal wgsl snapshots were updated, since the generated code now indexes the source by destination component.

Checklist

  • I, a human, have self-reviewed this PR and fully understand the changes within.
  • I have made or updated tests where possible.
  • All of my commits are properly scoped, compile successfully, and pass all tests.
  • This PR does not make sense to split up into smaller PRs.
  • An LLM was involved in the authoring of this code.

@pngdrift
pngdrift force-pushed the agal-single-component-write-mask branch 2 times, most recently from 1551734 to 826919e Compare November 4, 2026 14:23
@danielhjacobs danielhjacobs added A-rendering Area: Rendering & Graphics T-fix Type: Bug fix (in something that's supposed to work already) labels Nov 4, 2026
@Lord-McSweeney Lord-McSweeney added stage3d llm The PR contains mostly LLM-generated code labels Nov 4, 2026
@pngdrift
pngdrift force-pushed the agal-single-component-write-mask branch from d08c0af to b93dbaa Compare November 7, 2026 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-rendering Area: Rendering & Graphics llm The PR contains mostly LLM-generated code stage3d T-fix Type: Bug fix (in something that's supposed to work already)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants