Repository navigation
Avm2 xml nul charref - #25089
Open
va-moviestarplanet wants to merge 2 commits into
Open
Avm2 xml nul charref#25089va-moviestarplanet wants to merge 2 commits into
va-moviestarplanet wants to merge 2 commits into
Conversation
Flash Player decodes `�` and `�` in XML text and attributes to a NUL character, and escapes it back as `�`. quick-xml rejects code point 0, so Ruffle kept the reference as literal text. AVM1 is left unchanged, as it hasn't been checked against Flash Player. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Cover decimal and hex NUL references in text and attributes, and writing NUL back out with toXMLString(). The expected output was recorded in Adobe AIR 50. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Encountered an issue where MovieStarPlanet’s text fields beginning with
�, shows up as visible “�:” text in Ruffle.Caused by an issue where AVM2 XML, such as ;
�, �, � and similar stay as text.In Flash these decode to a NUL character in text and attributes. Checked in Adobe AIR 50.
The changes only affect AVM2, AVM1 is untouched.
Testing
SWF test avm2/xml_unescaping_nul_char_ref will fails on every line without the fix, and its expected output was recorded in AIR. The existing avmplus test bug_478501 now passes, so its known_failure is removed.
Checklist