Repository navigation
Conversation
cmdocmd
force-pushed
the
fix-filter-mask-jitter
branch
from
November 8, 2026 19:43
dbb07be to
56c27a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes jitter in stationary filtered content when an animated mask changes bounds.
Mask children are excluded from render bounds so their animation does not shift the bitmap cache origin. Script-visible bounds remain unchanged.
Testing
Adds
visual/cache_as_bitmap/animated_mask_filter_bounds, using an existing Ruffle test image and references from Adobe Flash Player 32.The test covers:
It compares traces of bitmap, mask, and container bounds against Flash. Image comparisons at three animation checkpoints and the final state verify that stationary content stays still while clipping and content movement update correctly.
The capture checkpoints have identical visible control positions but different oversized mask bounds, allowing the same Adobe stage reference to be reused.
The test passes with both changes and fails when either change is removed.
Checklist