Repository navigation
Require Rails 8.1+ and allow JSON 3 - #179
Merged
Merged
Conversation
Contributor
Danger ReportNo issues found. |
moskvin
changed the title
moskvin
marked this pull request as ready for review
September 30, 2026 23:21
moskvin
changed the title
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The documented 8.1.4+ support conflicts with the gemspec’s Rails < 8.2 constraint.
Review effort: Balanced
Findings: 2
Open (2)
What changed in this PR
Limits the gem to Rails 8.1.4–8.1.x while enabling JSON 3 compatibility.
Changes:
- Removes the JSON
< 3.0constraint. - Updates CI to test JSON 2/3 across Ruby 3.2–3.4.
- Updates compatibility documentation and changelog.
| File | Description |
|---|---|
README.md |
Updates the public compatibility matrix. |
grape-swagger-rails.gemspec |
Revises Rails and JSON dependency constraints. |
Gemfile |
Supports configurable Rails and JSON versions. |
CLAUDE.md |
Updates repository compatibility guidance. |
CHANGELOG.md |
Records the compatibility change. |
.github/workflows/test.yml |
Tests the new Ruby/Rails/JSON matrix. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…ange in compatibility table' Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
… in compatibility matrix' Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Jack12816
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
json < 3.0upper bound.json < 3.0dependency constraint #178