CARDAMOM: documentation revisions from data-producer review - #98
Draft
braghiere wants to merge 1 commit into
Draft
CARDAMOM: documentation revisions from data-producer review#98braghiere wants to merge 1 commit into
braghiere wants to merge 1 commit into
Conversation
Doc/metadata-only follow-up to rubisco-sfa#96; no conversion logic changes (output netCDFs change only in their comment attributes). - Correct the high-SWE mechanism: not unbounded accumulation for lack of a glacier store, but the snowpack (simpler melt routine than soil ice) acting as the convenient store to meet joint TWS/runoff constraints where SCF saturates and GRUN runoff cannot represent prior-year precipitation; constrained runoff itself remains realistic. - Reframe deep soil-water columns as the same attribution problem: all storage anomalies go to snow/soil states (melting glaciers, drying lakes). - ice caps -> glaciers (Greenland/Antarctica are already masked out). - Hedge the masked-cell diagnoses as working notes / known issues in progress, per producer guidance. - nee comment: the reco-gpp offset is a property of per-variable ensemble medians (non-normal distributions), not a mass-closure error. - Overlap table: define same dataset / same observable / related / circular; downgrade nbp (CMS-Flux vs GCP/Hoffman are distinct products); clarify the cVeg/XuSaatchi2021 wording. - Reframe non-independence as multi-constraint statistical fusion (a strength), scoped to the benchmarking question; add fire to the reco constraint chain (NBE = reco + fFire - gpp). - Soil layer depths: fitted effective-depth parameters, available in the Zenodo archive (doi:10.5281/zenodo.14521190), now linked; add the irrigation/rooting-depth caveat.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation-only follow-up to #96, incorporating review comments from the dataset lead author (T. Eren Bilir). No conversion logic changes; output netCDFs differ only in their
commentattributes.neevsreco − gppoffset attributed to medians of non-normal distributions, not a mass-closure error.nbpdowngraded (CMS-Flux ≠ GCP/Hoffman); fire added to therecoconstraint chain (NBE = reco + fFire − gpp).Deferred: per-variable descriptions of how assimilation shapes each output.