docs: recommend TransactionLimiter for bounding untrusted zone input#1281
Open
mohammedix88 wants to merge 1 commit into
Open
docs: recommend TransactionLimiter for bounding untrusted zone input#1281mohammedix88 wants to merge 1 commit into
mohammedix88 wants to merge 1 commit into
Conversation
Added a warning about handling untrusted input when building zones, including a code example for using TransactionLimiter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation-only follow-up to the
limitingbranch discussion.Adds a note to
doc/zone-make.rst:dns.zone.from_text/from_fileapply every record as a transaction change with no default limit, so untrusted input (e.g. a large$GENERATErange or an oversized zone) can exhaust memory/CPU. Passing adns.transaction.TransactionLimiterastransaction_setupbounds this, raisingdns.transaction.TooManyChanges; the default stays unlimited for backwards compatibility.No code changes; the example uses the API as it exists on the
limitingbranch. Happy to also add a shortSECURITY.mdnote and/or API-reference entries forTransactionLimiter/TooManyChangesif you'd like.