Skip to content

chore: migrate linting to Rslint and Prettier#27

Merged
chenjiahan merged 1 commit into
mainfrom
chenjiahan/migrate-rslint-prettier
Apr 28, 2026
Merged

chore: migrate linting to Rslint and Prettier#27
chenjiahan merged 1 commit into
mainfrom
chenjiahan/migrate-rslint-prettier

Conversation

@chenjiahan
Copy link
Copy Markdown
Member

This PR replaces Biome with the linting and formatting setup used by the plugin template. It adds Rslint and Prettier configs, updates package scripts and pre-commit hooks, migrates VS Code recommendations, and applies Prettier formatting to tracked files.

Copilot AI review requested due to automatic review settings April 28, 2026 09:21
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

This PR migrates the repo’s linting/formatting setup from Biome to Rslint + Prettier, aligning tooling and editor configs with the plugin template.

Changes:

  • Replace Biome with @rslint/core and Prettier; add corresponding config/ignore files.
  • Update package scripts, hooks, and VS Code recommendations to use the new toolchain.
  • Apply Prettier-driven formatting adjustments across configs/docs/tests.

Reviewed changes

Copilot reviewed 17 out of 23 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
test/index.test.ts Adjust test mocks/types to satisfy updated TypeScript + formatting/lint rules.
test/doc/tsconfig.json Formatting-only whitespace cleanup.
test/doc/tsconfig.build.json Formatting-only newline/indent cleanup.
test/doc/package.json Formatting-only newline/indent cleanup.
test/doc/docs/zh/index.mdx Formatting-only newline/indent cleanup.
test/doc/docs/zh/Button.mdx Prettier formatting for JSX-like MDX component usage.
test/doc/docs/en/index.mdx Formatting-only newline/indent cleanup.
test/doc/docs/en/Button.mdx Prettier formatting for JSX-like MDX component usage.
src/logger.ts Minor formatting of constructor parameter destructuring.
rslint.config.ts Add Rslint configuration using the TS recommended preset.
pnpm-workspace.yaml Quote style formatting update.
package.json Swap lint/format tooling; update scripts and pre-commit hook behavior; add dev deps.
biome.json Remove Biome configuration (tooling migration).
README.zh-CN.md Prettier formatting (quotes/blank lines) in documentation examples.
README.md Prettier formatting (quotes/blank lines) in documentation examples.
.vscode/settings.json Switch default formatter to Prettier.
.vscode/extensions.json Recommend Rslint + Prettier extensions.
.prettierrc Add Prettier configuration (single quotes).
.prettierignore Add ignore rules for artifacts/lockfile.
.github/workflows/test.yml Quote style formatting update.
.github/workflows/release.yml Quote style formatting update.
.github/renovate.json5 Convert to JSON5-style keys/quotes consistent with Prettier.
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread package.json
Comment thread package.json
Comment thread package.json
Comment thread test/index.test.ts
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0834a465e6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread package.json
@chenjiahan chenjiahan merged commit 3360a2a into main Apr 28, 2026
4 of 6 checks passed
@chenjiahan chenjiahan deleted the chenjiahan/migrate-rslint-prettier branch April 28, 2026 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants