Skip to content

Revert "restore global settings function"#123

Open
graingert wants to merge 2 commits into
rsmbl:masterfrom
graingert:remove-deprecated-global-mutation
Open

Revert "restore global settings function"#123
graingert wants to merge 2 commits into
rsmbl:masterfrom
graingert:remove-deprecated-global-mutation

Conversation

@graingert

Copy link
Copy Markdown

This reverts commit e5424ce.

@graingert

Copy link
Copy Markdown
Author

this will be a major (breaking) change: version bump to 3.x?

@TheEssem

TheEssem commented Feb 6, 2018

Copy link
Copy Markdown

This. Getting rid of that function broke a project I'm working on, and the new "solution" breaks the project even more.

@jamescryer

Copy link
Copy Markdown
Member

@TheEssemCraft This PR is a breaking change, not a fix for a breaking change. Perhaps your issue is addressed by #130 ?

@kartikd5

kartikd5 commented Mar 6, 2018

Copy link
Copy Markdown

Hi Team,
I am trying to import resemble.js API in my angular 2 application. But it seems it is not supported in angular 2. I got the typings error for the dependent modules i.e. canvas-prebuilt. Please let me know if you have any reference for this or planning to support angular 2.

@graingert

Copy link
Copy Markdown
Author

That's just a TypeScript problem. Nothing to do with angular

@graingert

Copy link
Copy Markdown
Author

Also you should make a new issue and not hijack other threads

@kartikd5

kartikd5 commented Mar 6, 2018

Copy link
Copy Markdown

Sorry guys

Comment thread resemble.js Outdated
Co-Authored-By: Christopher Carman <carmanchris31@gmail.com>
@CLAassistant

CLAassistant commented Mar 13, 2020

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

❌ Thomas Grainger
❌ graingert


Thomas Grainger seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants