feat(ACC-246): Add HTTP snapshot targets#7
Merged
Conversation
linuskendall
changed the title
linuskendall
commented
Apr 29, 2026
| if file == nil { | ||
| return nil, fmt.Errorf("parse snapshot filename from Location header: %q", location) | ||
| } | ||
| file.FileName = locationURL.String() |
Member
Author
There was a problem hiding this comment.
instead of doing this, we could add a new field to the SnapshotFile which is download URL and place the locationURL in there. That would not overwrite the FIleName so the filename would be consistent with the filenames from sidecar snapshots.
HTTP snapshot targets now populate download_url with the full redirect
URL rather than overwriting file_name, keeping file_name as the bare
filename. Sidecar and folder-based scraping also populate download_url
pointing at the sidecar's /v1/snapshot/{name} endpoint.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
fernandodeluret
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing