Skip to content

Expose certificatee dataplaneapi version metric#34

Merged
ananthb merged 1 commit into
masterfrom
fix/certificatee-dpapi-version-metric
Jun 14, 2026
Merged

Expose certificatee dataplaneapi version metric#34
ananthb merged 1 commit into
masterfrom
fix/certificatee-dpapi-version-metric

Conversation

@ananthb

@ananthb ananthb commented Jun 14, 2026

Copy link
Copy Markdown
Member

Summary:

  • replace certificatee endpoint state rollout reporting with certificatee_dataplaneapi_version{version="v2"|"v3"}
  • mark 404 from the v3 runtime certificate endpoint as dataplaneapi v2 and successful probes as v3
  • update certificatee tests and metric docs

Tests:

  • /usr/local/go/bin/go test ./cmd/certificatee
  • /usr/local/go/bin/go test ./...

@ananthb ananthb merged commit 7943449 into master Jun 14, 2026
1 check passed
@ananthb ananthb deleted the fix/certificatee-dpapi-version-metric branch June 14, 2026 10:59
@github-actions

Copy link
Copy Markdown

Code Coverage Report

Total Coverage: total: (statements) 38.3%

Coverage by function
github.com/vinted/certificator/cmd/certificatee/health.go:27:		newCertificateeHealthChecker	100.0%
github.com/vinted/certificator/cmd/certificatee/health.go:38:		certificateeHealthMaxSyncAge	75.0%
github.com/vinted/certificator/cmd/certificatee/health.go:46:		Check				87.5%
github.com/vinted/certificator/cmd/certificatee/health.go:78:		MarkEndpointSyncSuccess		80.0%
github.com/vinted/certificator/cmd/certificatee/health.go:88:		lastSync			100.0%
github.com/vinted/certificator/cmd/certificatee/helpers.go:9:		createHAProxyClients		0.0%
github.com/vinted/certificator/cmd/certificatee/main.go:24:		main				0.0%
github.com/vinted/certificator/cmd/certificatee/main.go:76:		maybeUpdateCertificates		0.0%
github.com/vinted/certificator/cmd/certificatee/main.go:92:		processHAProxyEndpoint		37.0%
github.com/vinted/certificator/cmd/certificatee/main.go:186:		setDataPlaneAPIVersion		100.0%
github.com/vinted/certificator/cmd/certificatee/main.go:196:		shouldUpdateCertificate		0.0%
github.com/vinted/certificator/cmd/certificatee/main.go:215:		shouldUpdateForLiveExpiry	100.0%
github.com/vinted/certificator/cmd/certificatee/main.go:233:		shouldUpdateForSerialMismatch	100.0%
github.com/vinted/certificator/cmd/certificatee/main.go:243:		updateCertificate		0.0%
github.com/vinted/certificator/cmd/certificatee/main.go:265:		buildPEMBundle			0.0%
github.com/vinted/certificator/cmd/certificatee/main.go:291:		endsWith			0.0%
github.com/vinted/certificator/cmd/certificator/main.go:20:		main				0.0%
github.com/vinted/certificator/pkg/acme/acme.go:27:			GetEmail			0.0%
github.com/vinted/certificator/pkg/acme/acme.go:32:			GetRegistration			0.0%
github.com/vinted/certificator/pkg/acme/acme.go:37:			GetPrivateKey			0.0%
github.com/vinted/certificator/pkg/acme/acme.go:42:			NewClient			0.0%
github.com/vinted/certificator/pkg/acme/acme.go:61:			setupClient			0.0%
github.com/vinted/certificator/pkg/acme/acme.go:80:			setupAccount			0.0%
github.com/vinted/certificator/pkg/acme/acme.go:118:			newAccount			0.0%
github.com/vinted/certificator/pkg/acme/acme.go:130:			getAccountKey			0.0%
github.com/vinted/certificator/pkg/acme/acme.go:159:			registerAccount			0.0%
github.com/vinted/certificator/pkg/acme/acme.go:177:			recoverAccount			0.0%
github.com/vinted/certificator/pkg/acme/acme.go:211:			saveAccount			0.0%
github.com/vinted/certificator/pkg/acme/acme.go:221:			saveKey				0.0%
github.com/vinted/certificator/pkg/certificate/certificate.go:18:	ObtainCertificate		0.0%
github.com/vinted/certificator/pkg/certificate/certificate.go:50:	GetCertificate			0.0%
github.com/vinted/certificator/pkg/certificate/certificate.go:68:	NeedsReissuing			0.0%
github.com/vinted/certificator/pkg/certificate/certificate.go:96:	arraysEqual			0.0%
github.com/vinted/certificator/pkg/certificate/certificate.go:110:	arrayContains			0.0%
github.com/vinted/certificator/pkg/certificate/certificate.go:119:	VaultCertLocation		0.0%
github.com/vinted/certificator/pkg/certificate/certificate.go:123:	storeCertificateInVault		0.0%
github.com/vinted/certificator/pkg/certmetrics/metrics.go:79:		StartMetricsServer		0.0%
github.com/vinted/certificator/pkg/certmetrics/metrics.go:104:		newHandler			100.0%
github.com/vinted/certificator/pkg/certmetrics/metrics.go:128:		PushMetrics			0.0%
github.com/vinted/certificator/pkg/config/config.go:73:			LoadConfig			0.0%
github.com/vinted/certificator/pkg/haproxy/client.go:57:		Error				0.0%
github.com/vinted/certificator/pkg/haproxy/client.go:63:		IsHTTPStatus			100.0%
github.com/vinted/certificator/pkg/haproxy/client.go:68:		unexpectedStatusError		100.0%
github.com/vinted/certificator/pkg/haproxy/client.go:77:		NewClient			100.0%
github.com/vinted/certificator/pkg/haproxy/client.go:112:		NewClients			92.3%
github.com/vinted/certificator/pkg/haproxy/client.go:137:		Endpoint			100.0%
github.com/vinted/certificator/pkg/haproxy/client.go:142:		doRequest			88.9%
github.com/vinted/certificator/pkg/haproxy/client.go:160:		parseAPITime			66.7%
github.com/vinted/certificator/pkg/haproxy/client.go:173:		getConfigVersion		66.7%
github.com/vinted/certificator/pkg/haproxy/client.go:238:		ListCertificates		100.0%
github.com/vinted/certificator/pkg/haproxy/client.go:252:		ListCertificateRefs		90.9%
github.com/vinted/certificator/pkg/haproxy/client.go:294:		GetCertificateDetail		68.4%
github.com/vinted/certificator/pkg/haproxy/client.go:336:		UpdateCertificate		80.0%
github.com/vinted/certificator/pkg/haproxy/client.go:368:		CreateCertificate		78.3%
github.com/vinted/certificator/pkg/haproxy/client.go:409:		DeleteCertificate		92.9%
github.com/vinted/certificator/pkg/haproxy/client.go:433:		ExtractDomainFromPath		100.0%
github.com/vinted/certificator/pkg/haproxy/client.go:453:		NormalizeDomainForVault		0.0%
github.com/vinted/certificator/pkg/haproxy/client.go:461:		IsExpiring			100.0%
github.com/vinted/certificator/pkg/haproxy/client.go:473:		NormalizeSerial			100.0%
github.com/vinted/certificator/pkg/haproxy/client.go:506:		Error				100.0%
github.com/vinted/certificator/pkg/haproxy/client.go:510:		Info				0.0%
github.com/vinted/certificator/pkg/haproxy/client.go:514:		Debug				100.0%
github.com/vinted/certificator/pkg/haproxy/client.go:518:		Warn				0.0%
github.com/vinted/certificator/pkg/haproxy/client.go:523:		toLogrusFields			85.7%
github.com/vinted/certificator/pkg/vault/vault.go:18:			NewVaultClient			0.0%
github.com/vinted/certificator/pkg/vault/vault.go:27:			TokenLookupSelf			0.0%
github.com/vinted/certificator/pkg/vault/vault.go:39:			KVWrite				0.0%
github.com/vinted/certificator/pkg/vault/vault.go:53:			KVRead				0.0%
github.com/vinted/certificator/pkg/vault/vault.go:74:			vaultFullPath			0.0%
total:									(statements)			38.3%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant