Skip to content

Use fixed version for rmw_fastrtps_shared_cpp dependency - #906

Open
MiguelCompany wants to merge 2 commits into
lyricalfrom
miguelcompany/fixed-dependency/lyrical
Open

Use fixed version for rmw_fastrtps_shared_cpp dependency#906
MiguelCompany wants to merge 2 commits into
lyricalfrom
miguelcompany/fixed-dependency/lyrical

Conversation

@MiguelCompany

Copy link
Copy Markdown
Collaborator

Description

Package rmw_fastrtps_shared_cpp exists only to contain code that is shared by the other two packages in this repository.
It is not meant to be used directly by a user, and we sometimes allow ABI breaks within a distribution, since we assume that the three packages will be updated at the same time.

This makes the coupling explicit by requiring the versions to be in sync.

Fixes #905

Is this user-facing behavior change?

Did you use Generative AI?

No.

Additional Information

This targets lyrical in order to fix #905.
We shall do similar PRs for other branches.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

@fujitatomoya fujitatomoya left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this is easiest way to address the situation right away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants