Fix backtrace call and variable setting in CMake#572
Open
AviaAv wants to merge 1 commit into
Open
Conversation
Signed-off-by: Avia Avraham <145359432+AviaAv@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Two likely issues in
cmake/check_c_compiler_uses_glibc.cmake:1. Type mismatch.
backtrace(&buffer, size)passesvoid *(*)[1]wherevoid **is expected. On gcc >= 14 (default-error on-Wincompatible-pointer-types), the probe fails to compile on glibc. Fix: drop the&.2. Result not propagated.
set(${result_variable} ${result_variable} PARENT_SCOPE)looks like it's missing a$. In a small repro,if(USES_GLIBC)evaluates truthy regardless of probe outcome. Fix:${${result_variable}}.Is this user-facing behavior change?
Possibly.
_GNU_SOURCEwould only be defined when glibc is actually detected, and the configure log on gcc >= 14 + glibc would no longer printPerforming Test USES_GLIBC - Failed.Did you use Generative AI?
Yes. Claude Code helped diagnose and verify. I reviewed the changes myself.
Additional Information
Repro for 1:
gcc -Werror=incompatible-pointer-typeson the extracted snippet. Repro for 2: minimalCMakeLists.txtcalling the function and printing${USES_GLIBC}.