Skip to content

Address rcl API change and uninitialized rosidl sequence fields - #457

Merged
christophebedard merged 2 commits into
ros2:rollingfrom
David-LP99:fix/rcl_api_change
Sep 28, 2026
Merged

christophebedard merged 2 commits into
ros2:rollingfrom
David-LP99:fix/rcl_api_change

Conversation

@David-LP99

@David-LP99 David-LP99 commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

Description

This PR aims to update the rolling branch fixing issues that appeared due to changes in other repositories.

Main changes:

Is this user-facing behavior change?

Did you use Generative AI?

Claude Code Opus 4.5 was used in the investigation and resolution of this issue.

Additional Information

Some micro-ROS demos and application don't work with the latest version of rolling without these changes.

Includes the necessary changes to be compatible with the
rclc API changes from ros2/rcl#1295.

Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>
@David-LP99 David-LP99 changed the title Address rcl API change Address rcl API change and uninitialized rosidl sequence fields Sep 28, 2026
Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>

@christophebedard christophebedard left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Today's scheduled CI job failed (https://github.com/ros2/rclc/actions/runs/36434963468/job/108970377166#step:6:488) and CI passes for this PR, so LGTM.

However, the Rpr job is required to merge the PR, yet it isn't triggered because of an issue with GitHub. IIUC, we need to delete the hook and recreate it, but I personally don't have the permissions to do it

@christophebedard

Copy link
Copy Markdown
Member

@ros-pull-request-builder retest this please

@christophebedard

Copy link
Copy Markdown
Member

@clalancette I think we also need to remove the requirement on Rpr__rclc__ubuntu_noble_amd64, because we've moved to Resolute. So I assume the job name won't be the same

@clalancette

Copy link
Copy Markdown

@clalancette I think we also need to remove the requirement on Rpr__rclc__ubuntu_noble_amd64, because we've moved to Resolute. So I assume the job name won't be the same

Good point, I've removed that for now.

@cottsay

cottsay commented Sep 28, 2026

Copy link
Copy Markdown
Member

@ros-pull-request-builder retest this please

@christophebedard

Copy link
Copy Markdown
Member

Alright. We only have an Lpr job and no Rpr job, but I think that's OK. This fix concerns both Rolling and Lyrical

@christophebedard
christophebedard merged commit e23b439 into ros2:rolling Sep 28, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants