Repository navigation
Address rcl API change and uninitialized rosidl sequence fields - #457
Conversation
Includes the necessary changes to be compatible with the rclc API changes from ros2/rcl#1295. Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>
Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>
christophebedard
left a comment
There was a problem hiding this comment.
Today's scheduled CI job failed (https://github.com/ros2/rclc/actions/runs/36434963468/job/108970377166#step:6:488) and CI passes for this PR, so LGTM.
However, the Rpr job is required to merge the PR, yet it isn't triggered because of an issue with GitHub. IIUC, we need to delete the hook and recreate it, but I personally don't have the permissions to do it
|
@ros-pull-request-builder retest this please |
|
@clalancette I think we also need to remove the requirement on |
Good point, I've removed that for now. |
|
@ros-pull-request-builder retest this please |
|
Alright. We only have an Lpr job and no Rpr job, but I think that's OK. This fix concerns both Rolling and Lyrical |
Description
This PR aims to update the
rollingbranch fixing issues that appeared due to changes in other repositories.Main changes:
is_rosidl_buffer/owns_rosidl_bufferfields that Update rosidl cpp path to emit rosidl::Buffer for uint8[] type rosidl#942 added to primitive sequences, which hand-built sequences left uninitializedIs this user-facing behavior change?
Did you use Generative AI?
Claude Code Opus 4.5 was used in the investigation and resolution of this issue.
Additional Information
Some micro-ROS demos and application don't work with the latest version of
rollingwithout these changes.