Move the headers from .h to .hpp by saikishor · Pull Request #100 · ros/urdfdom_headers

saikishor · 2026-04-06T19:33:26Z

As per the discussion over ros/urdfdom#230 (comment), I've moved the headers from .h to .hpp

ahcorde · 2026-04-09T16:21:46Z

Pulls: ros/urdfdom#250, #100
Gist: https://gist.githubusercontent.com/ahcorde/611f4084b55e4ff274ccd7e0d732b66d/raw/5219abd04cbab827d14e82f2a4404462b5425fe8/ros2.repos
BUILD args: --packages-above-and-dependencies urdfdom_headers urdfdom
TEST args: --packages-above urdfdom_headers urdfdom
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/18905

Linux
Linux-aarch64
Linux-rhel
Windows

ahcorde · 2026-04-17T08:20:13Z

Pulls: ros/urdfdom#250, #100
Gist: https://gist.githubusercontent.com/ahcorde/f729e1d69297fe6c7e76fa4d420b5c7a/raw/5219abd04cbab827d14e82f2a4404462b5425fe8/ros2.repos
BUILD args: --packages-above-and-dependencies urdfdom_headers urdfdom
TEST args: --packages-above urdfdom_headers urdfdom
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/18986

Linux
Linux-aarch64
Linux-rhel
Windows

scpeters · 2026-04-17T16:51:44Z

Pulls: ros/urdfdom#250, #100 Gist: https://gist.githubusercontent.com/ahcorde/f729e1d69297fe6c7e76fa4d420b5c7a/raw/5219abd04cbab827d14e82f2a4404462b5425fe8/ros2.repos BUILD args: --packages-above-and-dependencies urdfdom_headers urdfdom TEST args: --packages-above urdfdom_headers urdfdom ROS Distro: rolling Job: ci_launcher ci_launcher ran: https://ci.ros2.org/job/ci_launcher/18986

Linux

Linux-aarch64

Linux-rhel

Windows

CI is green but there are new downstream compiler warnings

https://ci.ros2.org/job/ci_linux/28749/gcc/

scpeters · 2026-04-17T17:10:45Z

including the changes in ros/urdfdom#250, there are downstream warnings in the following packages:

kdl_parser
robot_state_publisher
rviz_default_plugins
urdf
urdfdom (already commented in https://github.com/ros/urdfdom/pull/250/changes#r3101956295)

I think we should open pull requests in these repositories. We could also consider backporting .hpp files without deprecation notices to kilted

saikishor · 2026-04-17T17:18:08Z

Sound good. I'll try to do it. BTW what do you think about the version.hpp header?

scpeters · 2026-04-20T21:19:09Z

will merge this after the freeze and backport .hpp without deprecation to Lyrical

ahcorde · 2026-05-06T09:49:46Z

Pulls: ros/urdfdom#250, #100
Gist: https://gist.githubusercontent.com/ahcorde/7807971c80e701e4948f0fb0ed97c2b7/raw/5219abd04cbab827d14e82f2a4404462b5425fe8/ros2.repos
BUILD args: --packages-above-and-dependencies urdf_parser urdfdom_headers
TEST args: --packages-above urdf_parser urdfdom_headers
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/19163

Linux
Linux-aarch64
Linux-rhel
Windows

scpeters · 2026-05-12T16:44:39Z

sorry for the back and forth on this; since we didn't get the deprecation in Lyrical, let's split out deprecation of .h (b4048ab) to a separate PR that won't be backported

then this PR can add .hpp and be backported

mergify · 2026-06-21T23:14:30Z

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

Queue this pull request

ahcorde

@saikishor Do you mind to fix the conflict ?

saikishor · 2026-06-29T14:45:24Z

@saikishor Do you mind to fix the conflict ?

I'm a bit overwhelmed with work this week, I'll try to do it this week, if not the next week

Signed-off-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com>

Signed-off-by: Steve Peters <scpeters@intrinsic.ai>

mergify · 2026-07-20T11:41:45Z

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

Queue this pull request

saikishor · 2026-07-20T11:49:21Z

@scpeters I reverted the deprecation notes as you wanted

This reverts commit b895bf2. Signed-off-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com>

mergify · 2026-07-26T13:03:02Z

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

Queue this pull request

Conflicts are resolved

scpeters · 2026-07-26T13:04:42Z

I think this can be merged and backported since we removed the deprecation notices

saikishor · 2026-07-26T13:07:30Z

I think this can be merged and backported since we removed the deprecation notices

@scpeters should we add version headers to the package? So, the users can simply condition the includes based on the versions? That way they don't have to branch for fixing this

scpeters · 2026-07-26T22:47:14Z

I think this can be merged and backported since we removed the deprecation notices

@scpeters should we add version headers to the package? So, the users can simply condition the includes based on the versions? That way they don't have to branch for fixing this

Yes, I think that would also help with gazebosim/gz-cmake#548

scpeters · 2026-07-26T22:47:49Z

@ahcorde do we need to run CI again before merging?

ahcorde · 2026-07-27T07:07:29Z

Pulls: #100, ros/urdfdom#250
Gist: https://gist.githubusercontent.com/ahcorde/f99d7d485676e583cec2270e4b777e81/raw/5219abd04cbab827d14e82f2a4404462b5425fe8/ros2.repos
BUILD args: --packages-above-and-dependencies urdfdom urdfdom_headers
TEST args: --packages-above urdfdom urdfdom_headers
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/19971

Linux
Linux-aarch64
Linux-rhel
Windows

ahcorde · 2026-07-29T07:29:46Z

Pulls: ros/urdfdom#250, #100
Gist: https://gist.githubusercontent.com/ahcorde/e5e10dea553c66f0cec6e51ec1dda573/raw/5219abd04cbab827d14e82f2a4404462b5425fe8/ros2.repos
BUILD args: --packages-above-and-dependencies urdfdom urdfdom_headers
TEST args: --packages-above urdfdom urdfdom_headers
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/19997

Linux
Linux-aarch64
Linux-rhel
Windows

ahcorde requested changes Apr 7, 2026

View reviewed changes

Comment thread include/urdf_exception/exception.h

saikishor requested a review from ahcorde April 9, 2026 07:26

ahcorde approved these changes Apr 9, 2026

View reviewed changes

ahcorde mentioned this pull request Apr 9, 2026

Move the headers from .h to .hpp ros/urdfdom#250

Merged

scpeters reviewed Apr 17, 2026

View reviewed changes

Comment thread include/urdf_world/world.hpp Outdated

scpeters force-pushed the update/headers_to_hpp branch from 060b044 to b4048ab Compare April 17, 2026 16:47

scpeters approved these changes Apr 17, 2026

View reviewed changes

ahcorde previously requested changes Jun 29, 2026

View reviewed changes

saikishor and others added 4 commits July 20, 2026 13:40

Move all the .h headers to .hpp headers

7ec4586

Signed-off-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com>

Create the .h and point to the new .hpp files

927e77e

Signed-off-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com>

Add deprecation notices

b895bf2

Signed-off-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com>

use urdf_model/types.hpp

6bfd545

Signed-off-by: Steve Peters <scpeters@intrinsic.ai>

saikishor force-pushed the update/headers_to_hpp branch from 65f6b29 to 6bfd545 Compare July 20, 2026 11:41

Revert "Add deprecation notices"

923c710

This reverts commit b895bf2. Signed-off-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com>

saikishor force-pushed the update/headers_to_hpp branch from 1e0b0a4 to 923c710 Compare July 20, 2026 12:36

saikishor requested review from ahcorde and scpeters July 20, 2026 12:49

scpeters approved these changes Jul 26, 2026

View reviewed changes

scpeters merged commit 07ab70a into ros:rolling Jul 29, 2026
3 checks passed

Uh oh!

Conversation

saikishor commented Apr 6, 2026

Uh oh!

Uh oh!

ahcorde commented Apr 9, 2026

Uh oh!

ahcorde commented Apr 17, 2026

Uh oh!

Uh oh!

scpeters commented Apr 17, 2026

Uh oh!

scpeters commented Apr 17, 2026

Uh oh!

saikishor commented Apr 17, 2026

Uh oh!

scpeters commented Apr 20, 2026

Uh oh!

ahcorde commented May 6, 2026

Uh oh!

scpeters commented May 12, 2026

Uh oh!

mergify Bot commented Jun 21, 2026

Uh oh!

ahcorde left a comment

Choose a reason for hiding this comment

Uh oh!

saikishor commented Jun 29, 2026

Uh oh!

mergify Bot commented Jul 20, 2026

Uh oh!

saikishor commented Jul 20, 2026

Uh oh!

mergify Bot commented Jul 26, 2026

Uh oh!

scpeters commented Jul 26, 2026

Uh oh!

saikishor commented Jul 26, 2026

Uh oh!

scpeters commented Jul 26, 2026

Uh oh!

scpeters commented Jul 26, 2026

Uh oh!

ahcorde commented Jul 27, 2026

Uh oh!

ahcorde commented Jul 29, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants