feat(vendors): add Directus and Medusa to the cookie registry - #12
Merged
Merged
Conversation
Directus ships two necessary auth cookies (directus_session_token, directus_refresh_token) when an authenticated user is present. Medusa v2 defaults to JWT-in-localStorage (medusa_auth_token) rather than cookies. connect.sid is included for sites that opt into the non-default session auth mode. Also fixes the Available Vendors list in configuration.md, which was missing youtube, vimeo, cloudflare, and cloudflare-turnstile that had been added to the registry previously.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two new vendor entries for the `cookiePolicy.vendors` registry.
Directus
Two `necessary` cookies set after the user authenticates:
Source: `directus/directus` `api/src/controllers/auth.ts` + `api/src/constants.ts`. Defaults to cookie mode when `mode: 'cookie'` or `mode: 'session'` are used on login — the common SSR pattern.
Medusa
Medusa v2's default is JWT-in-localStorage, not cookies. Two entries:
Including both so users on either auth mode get an accurate policy table. The purpose text flags `connect.sid` as "only when session auth is enabled" so visitors reading the policy understand when it applies.
Incidental fix
The "Available vendors" list in `docs/guide/configuration.md` was missing four vendors that had been added to the registry previously (`youtube`, `vimeo`, `cloudflare`, `cloudflare-turnstile`). Brought the list back in sync.
Test plan
Follow-up ideas (not in this PR)