Include os.PathLike when typing path parameters

[adbac]

In order to pass pathlib.Path objects to the __init__ and save methods of font objects, this PR adds os.PathLike to the type hints of path parameters.

Currently, only RFont._init types pathOrObject this way, which means it isn't picked up by static type checkers when initializing objects.

[adbac]

Should we update the normalizeFilePath function signature to accept os.PathLike too? mypy checks fail on this point only.

[benkiel]

@knutnergaard you are the typing guru here, thoughts?

[knutnergaard]

On vacation, so can't check, but the pathlib.Path annotation in normalizeFilePath is likely too strict, and should be changed to os.pathLike.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.69%. Comparing base (4c387ec) to head (70e6b92).
⚠️ Report is 5 commits behind head on dev.

Additional details and impacted files

@@           Coverage Diff           @@
##              dev     #940   +/-   ##
=======================================
  Coverage   86.69%   86.69%           
=======================================
  Files          43       43           
  Lines        6727     6728    +1     
  Branches      972      972           
=======================================
+ Hits         5832     5833    +1     
  Misses        694      694           
  Partials      201      201           

Files with missing lines	Coverage Δ
Lib/fontParts/base/font.py	94.78% <100.00%> (ø)
Lib/fontParts/base/normalizers.py	98.96% <100.00%> (+<0.01%)	⬆️
Lib/fontParts/fontshell/font.py	92.85% <ø> (ø)

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[adbac]

Strange type checking error here, mypy still considers path to be of type str | Any | PathLike[Any] after calling os.path.splitext. splitext can only return a tuple of strings, right?

fontParts/Lib/fontParts/base/font.py

Lines 466 to 467 in 76a6673

	path = os.path.splitext(self.path)[0]
	path += ext

[benkiel]

@adbac As far as I can tell, yes, but clearly mypy disagrees...

[knutnergaard]

Strange type checking error here, mypy still considers path to be of type str | Any | PathLike[Any] after calling os.path.splitext. splitext can only return a tuple of strings, right?

I think it might return a tuple of bytes as well, depending on the input type. Converting path to string should do it.

[benkiel]

Hey @adbac This is not just a ruff formatting check, I'll run that and review!

[adbac]

Thanks!