Spider milovice - #1056
Merged
Merged
Conversation
Collaborator
Author
|
The changes in this PR are relatively minor and follow on from: tf-czu/spider#8
|
tajgr
marked this pull request as ready for review
August 10, 2026 15:15
…vice' into feature/spider-milovice
Member
|
OK, what is the current status? Should I review it? |
Collaborator
Author
|
Yes, it is ready. |
m3d
reviewed
Aug 15, 2026
|
|
||
|
|
||
| def get_desired_angle(speed, angular_speed): | ||
| def get_desired_angle(speed, angular_speed): # TODO to handle the calculation |
m3d
reviewed
Aug 15, 2026
| self.speed = config['max_speed'] | ||
| self.dist = config['dist'] | ||
| self.timeout = timedelta(seconds=config['timeout']) | ||
| self.stop_timeout = timedelta(seconds=config.get('stop_timeout', 1)) |
m3d
approved these changes
Aug 15, 2026
Collaborator
Author
|
Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains ongoing minor adjustments related to the Spider test in Milovice. I would like to just inform what i do (to avoid future surprise).